Re: v16 fails to build w/ Visual Studio 2015
Peter Eisentraut <peter@eisentraut.org>
From: Peter Eisentraut <peter@eisentraut.org>
To: Tom Lane <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Date: 2023-06-07T21:35:34Z
Lists: pgsql-hackers
On 07.06.23 23:16, Tom Lane wrote: > Noah Misch <noah@leadboat.com> writes: >> Visual Studio 2015 version "14.0.25431.01 Update 3" has an apparent compiler >> bug that causes the build to fail with "readfuncs.switch.c(522): fatal error >> C1026: parser stack overflow, program too complex (compiling source file >> src/backend/nodes/readfuncs.c)". While I wouldn't mind revoking support for >> Visual Studio 2015, changing the code to cope is easy. See attached. > > +1, I think this reads better anyway. I kind of like the style where there is only one return at the end, because it makes it easier to inject debugging code that inspects the return value.
Commits
-
Make parseNodeString() C idiom compatible with Visual Studio 2015.
- f9f31aa91f82 16.0 landed
-
Automatically generate node support functions
- 964d01ae90c3 16.0 cited