Horton

Re: PATCH: pgbench - option to build using ppoll() for larger connection counts

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Thomas Munro <thomas.munro@enterprisedb.com>, "Rady, Doug" <radydoug@amazon.com>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>, Andres Freund <andres@anarazel.de>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>
Date: 2018-08-09T21:46:10Z
Lists: pgsql-hackers

Attachments


On 08/09/2018 12:45 PM, Andrew Dunstan wrote:
>
>
> On 07/03/2018 07:52 PM, Andrew Dunstan wrote:
>>
>>
>> On 05/17/2018 01:23 AM, Thomas Munro wrote:
>>> On Tue, Mar 27, 2018 at 9:23 AM, Rady, Doug <radydoug@amazon.com> 
>>> wrote:
>>>> pgbench11-ppoll-v12.patch
>>> Hi Doug,
>>>
>>> FYI this patch is trying and failing to use ppoll() on Windows:
>>>
>>> https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.30 
>>>
>>>
>>
>>
>> It's still failing -  see 
>> <https://ci.appveyor.com/project/postgresql-cfbot/postgresql/build/1.0.4098>
>>
>> I'm setting this back to "Waiting on Author" until that's fixed.
>>
>
>
> The author hasn't replied, but the attached seems to have cured the 
> bitrot so that it at least applies. Let's see what the cfbot makes of 
> it and then possibly fix any Windows issues.
>
>
>


And there's still a Windows problem which I think is cured in the 
attached patch

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Use ppoll(2), if available, to wait for input in pgbench.

  2. Use pselect(2) not select(2), if available, to wait in postmaster's loop.