Re: Streaming Replication on win32
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@gmail.com>, Heikki Linnakangas <heikki.linnakangas@enterprisedb.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-02-15T16:33:24Z
Lists: pgsql-hackers
2010/2/15 Tom Lane <tgl@sss.pgh.pa.us>: > Magnus Hagander <magnus@hagander.net> writes: >> I changed your patch to this, because I find it a lot simpler. The >> change is in the checking in pgwin32_recv - there is no need to ever >> call waitforsinglesocket, we can just exit out early. > >> Do you see any issue with that? > > This definitely looks cleaner, but is there a reason not to use bool > instead of int here? No. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/