Re: Add on_trusted_init and on_untrusted_init to plperl UPDATED [PATCH]

Magnus Hagander <magnus@hagander.net>

From: Magnus Hagander <magnus@hagander.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alex Hunsaker <badalex@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Tim Bunce <Tim.Bunce@pobox.com>, pgsql-hackers@postgresql.org
Date: 2010-02-03T07:11:16Z
Lists: pgsql-hackers
On Wednesday, February 3, 2010, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Alex Hunsaker <badalex@gmail.com> writes:
>> On Tue, Feb 2, 2010 at 21:38, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> Alex Hunsaker <badalex@gmail.com> writes:
>>>> Yeah the both is gross.  How about:
>>>> plperl.on_plperl_init
>>>> plperl.on_plperlu_init
>>>> plperl.on_init ?
>>>
>>> I like the first two.  The problem of selecting a good name for the
>>> third one is easily solved: don't have it.  What would it be except
>>> a headache and a likely security problem?
>
>> Well its already in.
>
> Well *that's* easily fixed.  I think it's a bad idea, because it's
> unclear what you should put there and what the security implications
> are.  Two entirely separate init strings seems much easier to understand
> and administer.
>

+1.

It's a simple copy/paste in the config file if you want them the same
anyway, right?

/Magnus


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/