Re: pgsql: Define INADDR_NONE on Solaris when it's missing.
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers <pgsql-committers@postgresql.org>
Date: 2010-01-28T20:19:34Z
Lists: pgsql-hackers
On Thu, Jan 28, 2010 at 21:16, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Magnus Hagander <magnus@hagander.net> writes: >> On Thu, Jan 28, 2010 at 17:16, Tom Lane <tgl@sss.pgh.pa.us> wrote: >>> However, now that I know the real issue is you're using inet_addr, I >>> would like to know why you're not using inet_aton instead; or even >>> better, something that also copes with IPv6. > >> "Path of least resistance?" > >> Which method would you suggest? > > I haven't actually read the RADIUS patch, but generally we rely on > pg_getaddrinfo_all to interpret strings representing IP addresses. > Is there a reason not to use that? I don't think so. I'll look it over. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/