ECPG patch causes warning

Magnus Hagander <magnus@hagander.net>

From: Magnus Hagander <magnus@hagander.net>
To: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Michael Meskes <meskes@postgresql.org>
Date: 2010-01-10T12:24:46Z
Lists: pgsql-hackers
Hi!

The ecpg patch at
http://git.postgresql.org/gitweb?p=postgresql.git;a=commit;h=2f567552
causes a compile warning on win64 (andi think win32, but I didn't
recheck that). Specifically, line 140 of typename.c has:
            return (-type);

Where type is of type Oid, which is unsigned. This causes the warning:
  .\src\interfaces\ecpg\ecpglib\typename.c(140): warning C4146: unary
minus operator applied to unsigned type, result still unsigned


I think that line tries to fix that problem, but either it does it
wrong, or just in a way that MSVC can't deal with. I think you need to
cast it to a signed type as well?

-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/