Re: Change to config.pl processing in the msvc build environment
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Peter Eisentraut <peter_e@gmx.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-01-05T13:37:06Z
Lists: pgsql-hackers
On Sun, Jan 3, 2010 at 05:13, Andrew Dunstan <andrew@dunslane.net> wrote: > > > Peter Eisentraut wrote: >> >> On fre, 2010-01-01 at 16:32 +0100, Magnus Hagander wrote: >> >>> >>> I therefor propose that we rename this file to "config.pl.default", >>> and change the scripts to first load config.pl.default, and then load >>> config.pl if it exists. >>> >> >> I'd keep the naming so that the extension .pl is preserved. Helps >> editors and such. >> >> > > Right ... let's call it "default_config.pl" or some such. Otherwise it looks > sane enough. I don't think the "parens on trailing conditions" issue is > anything other than just a matter of taste. I often use them because I've > occasionally been caught by not doing so. Ok, I've applied this patch with the name change to config_default.pl (that way it still sorts next to config.pl etc, which was how Dave convinced me of the config.pl.default name in the first place :D) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/