Re: win32 socket definition
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2010-01-03T19:13:28Z
Lists: pgsql-hackers
On Sun, Jan 3, 2010 at 17:45, Peter Eisentraut <peter_e@gmx.net> wrote: > On fre, 2010-01-01 at 20:25 +0100, Magnus Hagander wrote: >> The win64 port has showed that we have two sockets declared >> incorrectly. They are supposed to be declared as SOCKET on win32, but >> they are declared as int. See attached patch. >> >> Given that SOCKET is actually defined as int on win32 (no warnings or >> anything there, just on win64), I'm inclined to apply this patch just >> to HEAD and not bother with backpatching. > > What is SOCKET defined as on win64? The socket definition is the same: typedef UINT_PTR SOCKET; But since it's defined as a pointer type, that makes it 64-bit on win64. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/