Re: [PATCH] Windows x64 [repost]
Magnus Hagander <magnus@hagander.net>
From: Magnus Hagander <magnus@hagander.net>
To: Tsutomu Yamada <tsutomu@sraoss.co.jp>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2010-01-01T19:45:44Z
Lists: pgsql-hackers
On Fri, Dec 4, 2009 at 11:42, Tsutomu Yamada <tsutomu@sraoss.co.jp> wrote: > > 2) use appropriate macro and datatypes for Windows API. > enables more than 32bits shared memory. Are you sure this one should use __noop, and not __nop? __noop: http://msdn.microsoft.com/en-us/library/s6btaxcs.aspx __nop: http://msdn.microsoft.com/en-us/library/aa983381.aspx I think __nop is what we want? Also, that turns it into "nop" and not "rep nop", no? Should we perhaps instead use __yield, per: http://msdn.microsoft.com/en-us/library/2b2h26kx.aspx Hopefully someone who knows this better than me can comment :-) -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/