Re: [PATCH] Windows x64 [repost]

Magnus Hagander <magnus@hagander.net>

From: Magnus Hagander <magnus@hagander.net>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: robertmhaas <robertmhaas@gmail.com>, greg <greg@2ndquadrant.com>, tsutomu <tsutomu@sraoss.co.jp>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2009-12-09T16:30:11Z
Lists: pgsql-hackers
2009/12/9 Tatsuo Ishii <ishii@postgresql.org>:
>> > Ok. Your suggestion is very helpfull. In general Tsutomu will wait for
>> > feedbacks come in, probably until Jan 15th.
>>
>> Of course there's also no rule that you couldn't review these sooner -
>> that might help get the ball rolling!
>
> Of course I did before he publishes the patches.  (I and he are
> working for the same company).  However I'm not a Windows programmer
> by no means. So my suggestion was mainly for designs...

:-)

As a reference for the future, please let us know when you have done
this before the patch is submitted. I think it's not very common that
just because you are in the same company, you have reviewed it. For
example, I highly doubt that Heikki reviews all the patches Bruce
post, or the other way around :-) And it's very useful to know that
one set of eyes have been on it already.


-- 
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/