Re: new heapcheck contrib module

Mark Dilger <mark.dilger@enterprisedb.com>

From: Mark Dilger <mark.dilger@enterprisedb.com>

To: Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>, Stephen Frost <sfrost@snowman.net>, Michael Paquier <michael@paquier.xyz>

Cc: Amul Sul <sulamul@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2020-10-08T01:01:24Z

Lists: pgsql-hackers

Attachments

v18-0001-Adding-function-verify_heapam-to-amcheck-module.patch (application/octet-stream) patch v18-0001
v18-0002-Adding-contrib-module-pg_amcheck.patch (application/octet-stream) patch v18-0002
v18-0003-Creating-non-throwing-interface-to-clog-and-slru.patch (application/octet-stream) patch v18-0003
v18-0004-Using-non-throwing-clog-interface-from-amcheck.patch (application/octet-stream) patch v18-0004
v18-0005-Adding-ACL-checks-for-verify_heapam.patch (application/octet-stream) patch v18-0005
(unnamed) (text/plain)

> On Oct 5, 2020, at 5:24 PM, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
> 
> There remain a few open issues and/or things I did not implement:
> 
> - This version follows Robert's suggestion of using pg_class_aclcheck() to check that the caller has permission to select from the table being checked.  This is inconsistent with the btree checking logic, which does no such check.  These two approaches should be reconciled, but there was apparently no agreement on this issue.

This next version, attached, has the acl checking and associated documentation changes split out into patch 0005, making it easier to review in isolation from the rest of the patch series.

Independently of acl considerations, this version also has some verbiage changes in 0004, in response to Andrey's review upthread.

Commits

Add pg_amcheck, a CLI for contrib/amcheck.
- 9706092839db 14.0 landed
Refactor and generalize the ParallelSlot machinery.
- f71519e545a3 14.0 landed
Generalize parallel slot result handling.
- 418611c84d00 14.0 landed
Move some code from src/bin/scripts to src/fe_utils to permit reuse.
- e955bd4b6c2b 14.0 landed
Factor pattern-construction logic out of processSQLNamePattern.
- 2c8726c4b0a4 14.0 landed
Doc: clean up verify_heapam() documentation.
- 4c49d8fc15ee 14.0 landed
Fix more portability issues in new amcheck code.
- 321633e17b07 14.0 landed
Fix portability issues in new amcheck test.
- 860593ec3bd1 14.0 landed
Try to avoid a compiler warning about using fxid uninitialized.
- 8bb0c9770e80 14.0 landed
Extend amcheck to check heap pages.
- 866e24d47db1 14.0 landed
Adjust walsender usage of xlogreader, simplify APIs
- 850196b610d2 13.0 cited
Improve checking of child pages in contrib/amcheck.
- d114cc538715 13.0 cited
Sanitize line pointers within contrib/amcheck.
- a9ce839a3137 12.0 cited
Fix possible sorting error when aborting use of abbreviated keys.
- 008c4135ccf6 10.0 cited