Re: GUC time unit spelling a bit inconsistent
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Peter Eisentraut <peter_e@gmx.net>, pgsql-hackers@postgreSQL.org
Date: 2007-06-18T16:31:14Z
Lists: pgsql-hackers
Alvaro Herrera <alvherre@commandprompt.com> writes: > - I was bitten by this too, not long ago, and took me a while to > understand why. Should we at least log a HINT or something? Yeah, a HINT listing the allowed spellings of the unit would go a long way here. > However, preffixing with M or K does not work: It's case-sensitive. We had that argument already, but I still think this decision was wrong. > - In shared_buffers, these work: > 8MB > 8 MB > These don't work: > 8M B > 8 M B Looking at the code, spaces before the unit are allowed, but not spaces within or after. I agree with disallowing embedded spaces, I think, but not allowing trailing spaces is inconsistent with our practice in other cases (in particular, these very same variables, when written as pure numbers...) regards, tom lane