Horton

Re: AIX support - alignment issues

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Geoghegan <pg@bowt.ie>, Noah Misch <noah@leadboat.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-07-02T21:31:54Z
Lists: pgsql-hackers 
Andres Freund <andres@anarazel.de> writes:
> What made me look at this issue right now is that the alignment issue lead the
> 56bit relfilenode patch to move the relfilenode field to the start of pg_class
> (ahead of the oid),

Agreed, up with that we should not put.  However ...

> because a 64bit value cannot be after a NameData.

... this coding rule strikes me as utterly ridiculous.  Why can't we
instead insist that NAMEDATALEN must be a multiple of 8?  Anyone who
tries to make it different from that is likely to be wasting padding
space even on platforms where there's not a deeper problem.

			regards, tom lane

Commits

  1. Doc: Acknowledge historically supported CPUs and OSes.

  2. Further tidy-up for old CPU architectures.

  3. Tidy up claimed supported CPUs and OSes.

  4. Remove HP/Intel Itanium support.

  5. Remove HP-UX port.

  6. Reorder subskiplsn in pg_subscription to avoid alignment issues.

  7. Tighten TAP tests' tracking of postmaster state some more.

  8. Reorder pg_sequence columns to avoid alignment issue