Horton

Re: Removing WITH clause support in CREATE FUNCTION, for isCachable and isStrict

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, Postgres hackers <pgsql-hackers@postgresql.org>
Date: 2018-01-26T17:30:12Z
Lists: pgsql-hackers 
Michael Paquier <michael.paquier@gmail.com> writes:
> On Thu, Jan 25, 2018 at 06:30:04PM -0500, Tom Lane wrote:
>> In short, I'm on board with removing the WITH clause.  I've not
>> reviewed the patch in detail, but will do so and push it if there's
>> not objections pretty soon.

> Glad to hear that, thanks!

And done.  I failed to resist the temptation to rename
compute_attributes_sql_style, since the "sql_style" bit no longer
conveys anything.  I'd always found compute_attributes_with_style
to be confusingly named --- seemed like it should have a sibling
compute_attributes_gracelessly, or something like that.

			regards, tom lane

Commits

  1. Remove the obsolete WITH clause of CREATE FUNCTION.

  2. Extend syntax of CREATE FUNCTION to resemble SQL99.