Horton

Re: pgsql: Add TAP tests for pg_verify_checksums

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>, pgsql-committers@lists.postgresql.org
Date: 2018-10-12T21:14:52Z
Lists: pgsql-hackers 

On 10/11/2018 08:17 PM, Michael Paquier wrote:
> Add TAP tests for pg_verify_checksums
>
> All options available in the utility get coverage:
> - Tests with disabled page checksums.
> - Tests with enabled test checksums.
> - Emulation of corruption and broken checksums with a full scan and
> single relfilenode scan.
>
> This patch has been contributed mainly by Michael Banck and Magnus
> Hagander with things presented on various threads, and I have gathered
> all the contents into a single patch.
>
> Author: Michael Banck, Magnus Hagander, Michael Paquier
> Reviewed-by: Peter Eisentraut
> Discussion: https://postgr.es/m/20181005012645.GE1629@paquier.xyz


We have some failures here on Windows. I suspect we might need to do a 
little more surgery like was done in commit 
efd7f8e36553cd32e445061cbbc80d32028f4248

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix issues with TAP tests of pg_verify_checksums

  2. Use whitelist to choose files scanned with pg_verify_checksums

  3. Add TAP tests for pg_verify_checksums

  4. Work around Msys weakness in Testlib.pm's command_like()