Re: Building with meson on NixOS/nixpkgs

Wolfgang Walther <walther@technowledgy.de>

From: Wolfgang Walther <walther@technowledgy.de>

To: Tristan Partin <tristan@partin.io>, Andres Freund <andres@anarazel.de>, Heikki Linnakangas <hlinnaka@iki.fi>

Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2024-08-17T21:43:37Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Support falling back to non-preferred readline implementation with meson
- 1091f8e0a48b 16.4 landed
- ed9d04463200 17.0 landed
- 67427f10093a 18.0 landed
Support absolute bindir/libdir in regression tests with meson
- 7f61882b638a 16.4 landed
- eb6765d57cfa 17.0 landed
- ff34ae368bdb 18.0 landed
Fallback to clang in PATH with meson
- 23be5206327c 16.4 landed
- a32ffeebfa63 17.0 landed
- 4d8de281b583 18.0 landed
Fallback to uuid for ossp-uuid with meson
- cc90d7823a6e 16.4 landed
- 469b97c52413 17.0 landed
- a00fae9d43e5 18.0 landed
meson: Add support for detecting ossp-uuid without pkg-config
- 2416fdb3ee30 18.0 cited

Tristan Partin:
> On Fri Aug 9, 2024 at 11:14 AM CDT, Andres Freund wrote:
>> commit 4d8de281b5834c8f5e0be6ae21e884e69dffd4ce
>> Author: Heikki Linnakangas <heikki.linnakangas@iki.fi>
>> Date:   2024-07-27 13:53:11 +0300
>>
>>     Fallback to clang in PATH with meson
>> [..]
>>
>> I think this is a bad change unfortunately - this way clang and llvm 
>> version
>> can mismatch. Yes, we've done it that way for autoconf, but back then 
>> LLVM
>> broke compatibility far less often.
> 
> See the attached patch on how we could make this situation better.

Works great.

With the correct clang on path:

Program clang found: YES 18.1.8 18.1.8 
(/nix/store/mr1y1rxkx59dr2bci2akmw2zkbbpmc15-clang-wrapper-18.1.8/bin/clang)

With a mismatching version on path:

Program 
/nix/store/x4gwwwlw2ylv0d9vjmkx3dmlcb7gingd-llvm-18.1.8/bin/clang clang 
found: NO found 16.0.6 but need: '18.1.8' 
(/nix/store/r85xsa9z0s04n0y21xhrii47bh74g2a8-clang-wrapper-16.0.6/bin/clang)

Yes, the match is exact, also fails with a newer version:

Program 
/nix/store/x4gwwwlw2ylv0d9vjmkx3dmlcb7gingd-llvm-18.1.8/bin/clang clang 
found: NO found 19.1.0 but need: '18.1.8' 
(/nix/store/rjsfx6sxjpkgd4f9hl9apm0n8dk7jd9w-clang-wrapper-19.1.0-rc2/bin/clang)

+1 for this patch.

Best,

Wolfgang