Re: PSA: we lack TAP test coverage on NetBSD and OpenBSD
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Date: 2019-01-22T16:44:57Z
Lists: pgsql-hackers
Attachments
- dont-use-srandom-in-pgbench-1.patch (text/x-diff) patch
Fabien COELHO <coelho@cri.ensmp.fr> writes: >>> Here is a POC which defines an internal interface for a PRNG, and use it >>> within pgbench, with several possible implementations which default to >>> rand48. >> I seriously dislike this patch. pgbench's random support is quite >> overengineered already IMO, and this proposes to add a whole batch of >> new code and new APIs to fix a very small bug. > My intention is rather to discuss postgres' PRNG, in passing. Full success > on this point:-) Our immediate problem is to fix a portability failure, which we need to back-patch into at least one released branch, ergo conservatism is warranted. I had in mind something more like the attached. regards, tom lane
Commits
-
Fix portability problem in pgbench.
- e6c3ba7fbfd5 12.0 landed
- 27d6bc68f98e 11.2 landed
-
Avoid assuming that we know the spelling of getopt_long's error messages.
- 434040159558 11.2 landed
- 251f57460f12 12.0 landed