Horton

Re: Three animals fail test-decoding-check on REL_10_STABLE

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

View thread View on postgr.es
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>, Thomas Munro <thomas.munro@enterprisedb.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Noah Misch <noah@leadboat.com>
Date: 2019-01-13T15:04:26Z
Lists: pgsql-hackers 
On 1/13/19 9:24 AM, Tom Lane wrote:
> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
>> On 1/12/19 2:03 PM, Tom Lane wrote:
>>> I wonder if it's practical to scrape DLSUFFIX out of src/Makefile.port
>>> instead of listing all the possibilities here.
>> I'd rather get make to tell us directly, something like:
>>     .PHONY: show_dl_suffix
>>     show_dl_suffix:
>>         @echo $(DLSUFFIX)
> No objection here, but of course you'd have to back-patch that into
> all active branches.
>
> (The Darwin case is slightly exciting, but it looks like you'd get
> the right answer as long as Makefile.shlib doesn't get involved.)
>
> 			



OK, I'll make that happen.


cheers


andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Fix up confusion over how to use EXTRA_INSTALL.