Re: Support custom socket directory in pg_upgrade

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>

To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

Cc: Alvaro Herrera <alvherre@2ndquadrant.com>, Daniel Gustafsson <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2018-12-01T20:48:27Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add a --socketdir option to pg_upgrade.
- 2d34ad843031 12.0 landed

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 30/11/2018 17:58, Tom Lane wrote:
>> Given that we have a patch for this approach, and no patch has been
>> offered for the /tmp approach, I'm kind of inclined to exercise
>> committer's discretion and proceed with this patch.  Will anybody
>> be seriously annoyed if I do?

> I think it's fair to proceed and leave open that someone submits a
> (possibly) better patch for a different approach in the future.

I don't think we'd be able to remove the --socketdir switch once added,
but certainly it doesn't preclude changing the algorithm for default
socket placement.

Pushed with minor code cleanup.

			regards, tom lane