Re: Fix tuple deformation with virtual generated NOT NULL columns
Chao Li <li.evan.chao@gmail.com>
From: Chao Li <li.evan.chao@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
Peter Eisentraut <peter@eisentraut.org>,
Andres Freund <andres@anarazel.de>,
Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-06-18T06:46:04Z
Lists: pgsql-hackers
> On Jun 18, 2026, at 14:27, David Rowley <dgrowleyml@gmail.com> wrote: > > On Thu, 18 Jun 2026 at 17:56, Chao Li <li.evan.chao@gmail.com> wrote: >> I don’t know why you added these commented SQL statements, I guess you have your reason. The problem is, in the 3 SELECTs, gtest21c should probably be gtest21d. > > This relates to the "-- keep these tests aligned with > generated_stored.sql" at the top of the file. > > I mentioned in [1]; >> I pushed the patch to add the new test after modifying it to also >> include the change in the generated_stored test, but with it commented >> out. This is the method that 83ea6c540 introduced. > > and this is meant to follow the same pattern. Thanks for the explanation. > > I've attached a version with the commented table names fixed. Thanks > for looking. > > David > > [1] https://postgr.es/m/CAApHDvrJBXEhet4=Es_wHBKdv5PCV5OGCaJOSmJexeaFqfmUHA@mail.gmail.com > <fix_jit_deform_for_virtual_generated_cols_v3.patch> This version feels all set. I also tried to build and run tests, all passed. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/
Commits
-
Update JIT tuple deforming code for virtual generated columns
- e9692de1d6f6 18 (unreleased) landed
- dc5116780846 19 (unreleased) landed
-
Add tuple deformation test for virtual generated columns
- 1f7dfe8c8ef7 19 (unreleased) landed
-
Fix tuple deforming with virtual generated columns
- 89eafad297a9 19 (unreleased) landed