Horton

Re: Autogenerate some wait events code and documentation

Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

View thread View on postgr.es
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-07-10T05:05:30Z
Lists: pgsql-hackers 
Hi,

On 7/9/23 9:36 AM, Michael Paquier wrote:
> On Sun, Jul 09, 2023 at 09:15:34AM +0200, Drouvot, Bertrand wrote:
>> I also noticed that you now provide the culprit line in case of parsing
>> failure (thanks for that).
> 
> Yes, that's mentioned in the commit message I quickly wrote in 0002.
> 
>>   #
>> -#   "C symbol in enums" "format in the system views" "description in the docs"
>> +#   "format in the system views" "description in the docs"
>>
>> Should we add a note here about the impact of the "format in the system views" on
>> the auto generated enum? (aka how it is generated based on its format)?
> 
> There is one, 

Yeah there is one in generate-wait_event_types.pl. I was wondering
to add one in wait_event_names.txt too (as this is the place where
no wait events would be added if any).

> but now that I look at it WAIT_EVENT repeated twice does
> not look great, so this could use "FooBarName" or equivalent:

+1 for "FooBarName"

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Commits

  1. Add "ABI_compatibility" regions to wait_event_names.txt

  2. Remove column for wait event names in wait_event_names.txt

  3. Use more consistent names for wait event objects and types

  4. Add information about line contents on parsing failure of wait_event_names.txt

  5. Remove double quotes from the second column of wait_event_names.txt

  6. Generate automatically code and documentation related to wait events

  7. Refactor some code related to wait events "BufferPin" and "Extension"

  8. doc: Fix ordering of entries in wait event table for I/O type