Horton

Re: Clean up some signal usage mainly related to Windows

Peter Eisentraut <peter@eisentraut.org>

View thread View on postgr.es
From: Peter Eisentraut <peter@eisentraut.org>
To: Tristan Partin <tristan@neon.tech>, pgsql-hackers@postgresql.org
Date: 2023-07-12T14:31:23Z
Lists: pgsql-hackers 
On 12.07.23 16:23, Tristan Partin wrote:
> It has come to my attention that STDOUT_FILENO might not be portable and
> fileno(3) isn't marked as signal-safe, so I have just used the raw 1 for
> stdout, which as far as I know is portable.

We do use STDOUT_FILENO elsewhere in the code, and there are even 
workaround definitions for Windows, so it appears it is meant to be used.

Commits

  1. Suppress -Wunused-result warning about write().

  2. Use signal-safe functions in signal handler