Horton

Re: Fix for Extra Parenthesis in pgbench progress message

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: btogiwarayuushi@oss.nttdata.com, pgsql-hackers@postgresql.org
Date: 2024-11-09T05:46:00Z
Lists: pgsql-hackers

Attachments


On 2024/11/08 11:47, Tatsuo Ishii wrote:
> I think you need to adjust
> 
> 		fprintf(stderr, "%*c\r", chars - 1, ' ');	/* Clear the current line */
> 
> to:
> 
> 		fprintf(stderr, "%*c\r", chars, ' ');	/* Clear the current line */
> 
> since now chars does not consider the EOL char. By clearing chars - 1,
> the closing parenthesis will be left on the screen.

You're right! I've updated the patch and attached v4.

About the back-patch: initially, there were concerns it might be too invasive,
as you told upthread. However, after our discussion, I think the latest version
is straightforward enough, and I'm okay with back-patching it. Thoughts?

Since the minor release freeze is already in effect, if we commit this patch,
we'll need to wait until the next minor releases are out next week before
the commit and back-patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

  1. Fix pgbench performance issue induced by commit af35fe501.

  2. pgbench: Ensure previous progress message is fully cleared when updating.