Re: BUG #18240: Undefined behaviour in cash_mul_flt8() and friends

Laurenz Albe <laurenz.albe@cybertec.at>

From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>, "Jonathan S. Katz" <jkatz@postgresql.org>
Cc: Michael Paquier <michael@paquier.xyz>, David Rowley <dgrowleyml@gmail.com>, exclusion@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2023-12-25T01:09:12Z
Lists: pgsql-bugs
On Sun, 2023-12-24 at 13:21 -0500, Tom Lane wrote:
> "Jonathan S. Katz" <jkatz@postgresql.org> writes:
> > I'm of the strong opinion that we should get rid of money. I personally 
> > haven't encountered it in the wild -- I'm sure it's there, but it seems 
> > limited -- and most apps that seriously deal with money will either user 
> > either "numeric" or an integer-based type.
> 
> Yeah, maybe we should just do it.  I was pleasantly surprised by how
> little push-back we got from nuking the 32-bit datetime types a few
> releases ago; perhaps this one would likewise not have much of a
> constituency.

There are questions on Stackoverflow:
https://stackoverflow.com/search?q=%5Bpostgresql%5D+money

But of course it is hard to say if these are production uses or just
experiments.

Yours,
Laurenz Albe



Commits

  1. Add overflow checks to money type.

  2. Reduce dependency to money data type in main regression test suite