Re: pgsql: Allow insert and update tuple routing and COPY for foreign table
Laurenz Albe <laurenz.albe@cybertec.at>
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Andres Freund <andres@anarazel.de>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>, Robert Haas <rhaas@postgresql.org>, pgsql-committers@lists.postgresql.org, pgsql-hackers@lists.postgresql.org
Date: 2019-04-23T06:59:14Z
Lists: pgsql-hackers
On Mon, 2019-04-22 at 14:07 -0700, Andres Freund wrote: > How about just applying the patch from v12 on? > > Then it is a behavior change in a major release, which is acceptable. > > It requires the imaginary FDW above to add an empty BeginForeignInsert > > callback function, but will unbreak FDW that slept through the change > > that added COPY support. > > I fail to see the advantage. It'll still require FDWs to be fixed to > work correctly for v11, but additionally adds another set of API > differences that needs to be fixed by another set of FDWs. I think this > ship simply has sailed. I can accept that (having fixed my own FDW), but I am worried that it will cause problems for FDW users. Well, I guess they can always avoid COPY if they don't want FDWs to crash. Yours, Laurenz Albe
Commits
-
Add FDW documentation notes about insert and update tuple routing and COPY.
- 53f48a2abb7b 11.3 landed
- 90fca7a35aa7 12.0 landed
-
Allow insert and update tuple routing and COPY for foreign tables.
- 3d956d9562aa 11.0 cited