Re: Refactoring on DROP/ALTER SET SCHEMA/ALTER RENAME TO statement

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Alvaro Herrera <alvherre@commandprompt.com>, Kohei KaiGai <kaigai@kaigai.gr.jp>, Dimitri Fontaine <dimitri@2ndquadrant.fr>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2011-11-17T22:29:29Z
Lists: pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Nov 17, 2011 at 4:26 PM, Alvaro Herrera
> <alvherre@commandprompt.com> wrote:
>> So the buildfarm broke due to this change, because citext does

> Thanks for fixing it.  Should we revert the original change?

I still think it's reasonable to remove the extra downcasing step,
but we'll have to document it as a change.  For instance, spelling
C as either "C" or 'C' would work differently now.  The fact that
the former is downcased seems quite surprising to me, so I don't
think anybody would say that this isn't a better definition, but
undoubtedly it could force people to change their source files.

			regards, tom lane