Re: elog(DEBUG2 in SpinLocked section.

Fujii Masao <masao.fujii@oss.nttdata.com>

From: Fujii Masao <masao.fujii@oss.nttdata.com>

To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2020-06-02T08:35:48Z

Lists: pgsql-hackers


On 2020/06/02 16:15, Kyotaro Horiguchi wrote:
> Hello.
> 
> I noticed that UpdateSpillStats calls "elog(DEBUG2" within
> SpinLockAcquire section on MyWalSnd.  The lock doesn't protect rb and
> in the first place the rb cannot be modified during the function is
> running.
> 
> It should be out of the lock section.

Thanks for the patch! It looks good to me.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

Commits

Fix instance of elog() called while holding a spinlock
- 4a9809e34d09 9.5.23 landed
- e7a134b5817b 9.6.19 landed
- 5ed8b4a981ed 10.14 landed
- b41a85f53317 11.9 landed
- 03aa25b6e34b 12.4 landed
- c1669fd5812a 13.0 landed
Don't call palloc() while holding a spinlock, either.
- 3d474a07934c 12.4 landed
- f88bd3139f3e 13.0 landed
- 7a8cb4a61e7e 11.9 landed
- 0c735c686a90 10.14 landed
Don't call elog() while holding spinlock.
- caa3c4242cf8 13.0 landed