Re: meson oddities
Peter Eisentraut <peter.eisentraut@enterprisedb.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>, Michael Paquier <michael@paquier.xyz>
Cc: Andrew Dunstan <andrew@dunslane.net>,
PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-11-15T16:07:05Z
Lists: pgsql-hackers
On 15.11.22 00:48, Andres Freund wrote: > We effectively do that with autoconf as well, except that we don't mention > that in pg_config --ldflags. Our linking rules include CFLAGS, see e.g.: > > %: %.o > $(CC) $(CFLAGS) $^ $(LDFLAGS) $(LDFLAGS_EX) $(LIBS) -o $@$(X) > > postgres: $(OBJS) > $(CC) $(CFLAGS) $(call expand_subsys,$^) $(LDFLAGS) $(LDFLAGS_EX) $(export_dynamic) $(LIBS) -o $@ > > ifdef PROGRAM > $(PROGRAM): $(OBJS) > $(CC) $(CFLAGS) $(OBJS) $(PG_LIBS_INTERNAL) $(LDFLAGS) $(LDFLAGS_EX) $(PG_LIBS) $(LIBS) -o $@$(X) > endif > > # Rule for building a shared library from a single .o file > %.so: %.o > $(CC) $(CFLAGS) $< $(LDFLAGS) $(LDFLAGS_SL) -shared -o $@ > > > Should we try that fact in pg_configin the meson build as well? It's up to the consumer of pg_config to apply CFLAGS and LDFLAGS as they need. But pg_config and pkg-config etc. should report them separately.
Commits
-
meson: Fix installation path computation
- 8f6858064b14 16.0 landed