Horton

Re: Upgrading pg_statistic to handle collation honestly

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2018-12-14T14:57:57Z
Lists: pgsql-hackers 
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 12/12/2018 16:57, Tom Lane wrote:
>> + 		stats->attrcollid = exprCollation(index_expr);
>> + 		/* XXX should we consult indcollation instead? */

> After looking through this again, I think the answer here is "yes".

Yeah, I was leaning towards that as well, but hadn't written the extra
code needed to make it so.  Will fix.

			regards, tom lane

Commits

  1. Make pg_statistic and related code account more honestly for collations.