Upgrading postmaster's log messages about bind/listen errors
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: pgsql-hackers@postgreSQL.org
Date: 2017-03-09T20:27:25Z
Lists: pgsql-hackers
Attachments
- add-address-to-bind-failure-msgs.patch (text/x-diff) patch
Over in https://www.postgresql.org/message-id/flat/201703072317.01345.john.iliffe%40iliffe.ca we spent quite a lot of effort to diagnose what turned out to be a simple networking misconfiguration. It would probably have taken a lot less effort if the postmaster were more forthcoming about exactly what address it's trying to bind to. I seem to recall having wanted to include that info in the messages many years ago, but at the time we lacked any reasonably-portable way to decode a struct addrinfo. Now we have pg_getnameinfo_all(), so PFA a patch to include the specific address in any complaint about failures in the socket/bind/listen sequence. For good measure I also added a DEBUG1 log message reporting successful binding to a port. I'm not sure if there's an argument for putting this out at LOG level (i.e. by default) --- any thoughts about that? There are probably a couple of example messages in the SGML docs that would need to be updated, but I've not trawled for them yet. regards, tom lane
Commits
-
Make logging about multixact wraparound protection less chatty.
- 5ed6fff6b729 10.0 landed
-
Improve postmaster's logging of listen socket creation.
- f9dfa5c97766 10.0 landed
-
Reduce log verbosity of startup/shutdown for launcher subprocesses.
- 6ec4c8584c45 10.0 landed