Re: dubious warning: FORMAT JSON has no effect for json and jsonb types

Peter Eisentraut <peter@eisentraut.org>

From: Peter Eisentraut <peter@eisentraut.org>

To: Merlin Moncure <mmoncure@gmail.com>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2023-08-18T05:59:34Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Remove dubious warning message from SQL/JSON functions
- dcfc49c1b652 16.0 landed
- 881cd9e581c2 17.0 landed

On 16.08.23 16:59, Merlin Moncure wrote:
> On Wed, Aug 16, 2023 at 8:55 AM Peter Eisentraut <peter@eisentraut.org 
> <mailto:peter@eisentraut.org>> wrote:
> 
>     This warning comes from parse_expr.c transformJsonValueExpr() and is
>     triggered for example by the following test case:
> 
>     SELECT JSON_OBJECT('foo': NULL::json FORMAT JSON);
>     WARNING:  FORMAT JSON has no effect for json and jsonb types
> 
>     But I don't see anything in the SQL standard that would require this
>     warning.  It seems pretty clear that FORMAT JSON in this case is
>     implicit and otherwise without effect.
> 
>     Also, we don't have that warning in the output case (RETURNING json
>     FORMAT JSON).
> 
>     Anyone remember why this is here?  Should we remove it?
> 
> 
> +1 for removing, on the basis that it is not suprising, and would 
> pollute logs for most configurations.

done