Re: [PATCH] Expose port->authn_id to extensions and triggers
Jacob Champion <pchampion@vmware.com>
From: Jacob Champion <pchampion@vmware.com>
To: "andres@anarazel.de" <andres@anarazel.de>
Cc: "michael@paquier.xyz" <michael@paquier.xyz>, "rjuju123@gmail.com" <rjuju123@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, "tgl@sss.pgh.pa.us" <tgl@sss.pgh.pa.us>, "sfrost@snowman.net" <sfrost@snowman.net>
Date: 2022-03-24T17:44:06Z
Lists: pgsql-hackers
Attachments
- since-v6.diff.txt (text/plain)
- v7-0001-Add-API-to-retrieve-authn_id-from-SQL.patch (text/x-patch) patch v7-0001
- v7-0002-Allow-parallel-workers-to-use-pg_session_authn_id.patch (text/x-patch) patch v7-0002
On Wed, 2022-03-23 at 16:54 -0700, Andres Freund wrote: > On 2022-03-23 23:06:14 +0000, Jacob Champion wrote: > > On Wed, 2022-03-23 at 19:00 -0400, Tom Lane wrote: > > > Hm. I was more envisioning getting the "sharable" info out of Port > > > entirely, although I'm not quite sure where it should go instead. > > > > If it helps, I can move the substruct out and up to a new global struct > > (MyProcShared?). At this point I think it's mostly search-and-replace. > > Perhaps alongside CurrentUserId etc in miscinit.c? It would be nicer if all > those were together in a struct, but oh well. Next draft in v7. My naming choices probably make even less sense now. Any ideas for names for "a bag of stuff that we want parallel workers to have too"? > Another option would be to make it a GUC. With a bit of care it could be > automatically synced by the existing parallelism infrastructure... Like a write-once, PGC_INTERNAL setting? I guess I don't have any intuition on how that would compare to the separate-global-and-accessor approach. Is the primary advantage that you don't have to maintain the serialization logic, or is there more to it? Thanks, --Jacob
Commits
-
Remove initialization of MyClientConnectionInfo at backend startup
- 701ac2cb1fa2 16.0 landed
-
Allow parallel workers to retrieve some data from Port
- d951052a9e02 16.0 landed