Re: Cleanup shadows variable warnings, round 1

> On Dec 3, 2025, at 14:42, Peter Smith <smithpb2250@gmail.com> wrote:
> 
> Patch v2-0001.
> 
> src/backend/backup/basebackup_incremental.c:
> PrepareForIncrementalBackup:
> 
> Instead of changing the var name from 'i' to 'u', you can fix this one
> by changing all the for loops to declare 'i' within the 'for ('.
> That way kills two birds with one stone: it removes the shadow warning
> and at the same time improves the scope of the loop variables.
> 
> 
> -       int                     i;
> 
> -       for (i = 0; i < num_wal_ranges; ++i)
> +       for (int i = 0; i < num_wal_ranges; ++i)
> 
> -       for (i = 0; i < num_wal_ranges; ++i)
> +       for (int i = 0; i < num_wal_ranges; ++i)
> 
> -       unsigned        i;
> 
> -               for (i = 0; i < nblocks; ++i)
> +               for (unsigned i = 0; i < nblocks; ++i)

Unfortunately that doesn’t work for my compiler (clang on MacOS), that’s why I renamed “I" to “u”.

By the way, Peter (S), thank you very much for reviewing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/