Re: Improve hash join's handling of tuples with null join keys

Tom Lane <tgl@sss.pgh.pa.us>

From: Tom Lane <tgl@sss.pgh.pa.us>
To: "Joel Jacobson" <joel@compiler.org>
Cc: "Chao Li" <li.evan.chao@gmail.com>, pgsql-hackers@lists.postgresql.org
Date: 2026-03-18T19:10:07Z
Lists: pgsql-hackers

Attachments

"Joel Jacobson" <joel@compiler.org> writes:
> I've tested v3-0001 and v3-0002 and can confirm the bug introduced
> in v3-0001 is fixed in v3-0002:

Thanks for testing!

I noticed from the cfbot that this patch wasn't building anymore.
nodeHash[join].c now need explicit inclusions of utils/tuplestore.h,
presumably as a result of Alvaro's recent header-inclusion cleanups.
Here's a v4 that fixes that; no other changes.

We're getting towards the end of the v19 development cycle, so
I'm planning to push this soon if there's not objections.

			regards, tom lane

Commits

  1. Improve hash join's handling of tuples with null join keys.