Horton

Re: Wait event that should be reported while waiting for WAL archiving to finish

Fujii Masao <masao.fujii@oss.nttdata.com>

View thread View on postgr.es
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
Date: 2020-02-13T06:35:50Z
Lists: pgsql-hackers

Attachments


On 2020/02/13 12:28, Michael Paquier wrote:
> On Thu, Feb 13, 2020 at 02:29:20AM +0900, Fujii Masao wrote:
>> When I saw pg_stat_activity.wait_event while pg_basebackup -X none
>> is waiting for WAL archiving to finish, it was either NULL or
>> CheckpointDone. I think this is confusing. What about introducing
>> new wait_event like WAIT_EVENT_BACKUP_WAIT_WAL_ARCHIVE
>> (BackupWaitWalArchive) and reporting it during that period?
> 
> Sounds like a good idea to me.  You need to be careful that this does
> not overwrite more low-level wait event registration though, so that
> could be more tricky than it looks at first sight.

Thanks for the advise! Patch attached.

I found that the wait events "LogicalRewriteTruncate" and
"GSSOpenServer" are not documented. I'm thinking to add
them into doc separately if ok.

Regards,

-- 
Fujii Masao
NTT DATA CORPORATION
Advanced Platform Technology Group
Research and Development Headquarters

Commits

  1. Add wait events for WAL archive and recovery pause.

  2. Add description about GSSOpenServer wait event into document.

  3. Add description about LogicalRewriteTruncate wait event into document.

  4. GSSAPI encryption support

  5. Create and use wait events for read, write, and fsync operations.