Horton

Re: Plug-in common/logging.h with vacuumlo and oid2name

Peter Eisentraut <peter.eisentraut@2ndquadrant.com>

View thread View on postgr.es
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-09-04T08:17:57Z
Lists: pgsql-hackers 
On 2019-08-20 03:28, Michael Paquier wrote:
> +					pg_log_error("\nfailed to remove lo %u: %s", lo,
> +								 PQerrorMessage(conn));

This newline should be removed.

progname can probably be made into a local variable now.

The rest looks good to me.

Do we need set_pglocale_pgservice() calls here if we're not doing NLS?
Does the logging stuff require it?  I'm not sure.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Make use of generic logging in vacuumlo and oid2name