Re: Enable data checksums by default

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: Nathan Bossart <nathandbossart@gmail.com>

Cc: Peter Eisentraut <peter@eisentraut.org>, Greg Sabino Mullane <htamfids@gmail.com>, Bruce Momjian <bruce@momjian.us>, Michael Paquier <michael@paquier.xyz>, Michael Banck <mbanck@gmx.net>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2024-10-07T09:37:04Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Avoid BufferGetLSNAtomic() calls during nbtree scans.
- e6eed40e4441 18.0 cited
doc PG 18 relnotes: Add incompatibility note about checksums now default
- 48814415d5aa 18.0 landed
Fix pg_upgrade's cross-version tests when old < 18
- 38c18710b37a 18.0 landed
initdb: Change default to using data checksums.
- 04bec894a04c 18.0 landed
Allow TAP tests to force checksums off when calling init()
- e7d0cf42b1ac 18.0 landed
initdb: Add new option "--no-data-checksums"
- 983a588e0b86 18.0 landed
Tweak docs to reduce possible impact of data checksums
- efd72a3d422b 18.0 landed

> On 3 Oct 2024, at 23:13, Nathan Bossart <nathandbossart@gmail.com> wrote:
> 
> On Tue, Oct 01, 2024 at 11:15:02AM -0400, Peter Eisentraut wrote:
>> I have committed 0001 (the new option) and 0004 (the docs tweak).  I think
>> there is consensus for the rest, too, but I'll leave it for a few more days
>> to think about.  I guess the test failure has to be addressed.
> 
> Here is a rebased patch with the test fix (for cfbot).  I have made no
> other changes.

+        Data checksums are enabled by default. They can be
+        disabled by use of <option>--no-data-checksums</option>.

Nitpick, but I think this should be an xref like how we link to --no-locale in
the -E docs: <xref linkend="app-initdb-no-data-checksums"/> instead.

LGTM otherwise.

--
Daniel Gustafsson