Horton

Re: pg_verifybackup: TAR format backup verification

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amul Sul <sulamul@gmail.com>, Sravan Kumar <sravanvcybage@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2024-10-02T19:00:30Z
Lists: pgsql-hackers 
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Oct 1, 2024 at 1:32 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Yes, mamba thinks this is OK.

> Committed.

Sadly, it seems adder[1] is even pickier than mamba:

../pgsql/src/backend/backup/basebackup_incremental.c: In function \342\200\230CreateIncrementalBackupInfo\342\200\231:
../pgsql/src/backend/backup/basebackup_incremental.c:179:30: error: assignment to \342\200\230json_manifest_per_file_callback\342\200\231 {aka \342\200\230void (*)(JsonManifestParseContext *, const char *, long long unsigned int,  pg_checksum_type,  int,  unsigned char *)\342\200\231} from incompatible pointer type \342\200\230void (*)(JsonManifestParseContext *, const char *, size_t,  pg_checksum_type,  int,  uint8 *)\342\200\231 {aka \342\200\230void (*)(JsonManifestParseContext *, const char *, unsigned int,  pg_checksum_type,  int,  unsigned char *)\342\200\231} [-Wincompatible-pointer-types]
  179 |         context->per_file_cb = manifest_process_file;
      |                              ^


			regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=adder&dt=2024-10-02%2014%3A09%3A58

Commits

  1. Adjust json_manifest_per_file_callback API in one more place.

  2. File size in a backup manifest should use uint64, not size_t.

  3. Fix some pg_verifybackup issues reported by Coverity.

  4. pg_verifybackup: Move some declarations to new pg_verifybackup.h

  5. pg_verifybackup: Move skip_checksums into verifier_context.

  6. Improve file header comments for astramer code.

  7. Move astreamer (except astreamer_inject) to fe_utils.

  8. Move recovery injector astreamer to a separate header file.

  9. Rename bbstreamer to astreamer.