Re: Incorrect logic in XLogNeedsFlush()

On Tue, 2025-09-09 at 16:29 -0400, Melanie Plageman wrote:
> On Wed, Sep 3, 2025 at 11:38 PM Dilip Kumar <dilipbalaut@gmail.com>
> wrote:
> > 
> > On Sat, Aug 30, 2025 at 4:16 AM Melanie Plageman
> > <melanieplageman@gmail.com> wrote:
> > 
> > > Why is it okay for other processes than the startup process to
> > > initialize LocalMinRecoveryPoint from ControlFile-
> > > >minRecoveryPoint
> > > during crash recovery?
> > 
> > During crash recovery we don't yet know the minRecoveryPoint until
> > we
> > replay all the WALs and once it is done it will be updated in the
> > ControlFile at PerformRecoveryXLogAction()-
> > >CreateEndOfRecoveryRecord().

...

> 
> Though, it seems like LocalMinRecoveryPoint must be getting
> incorrectly set elsewhere, otherwise this would have guarded us from
> examining the control file:

I am confused about whether we are discussing "incorrect" or "invalid".

Regards,
	Jeff Davis

> >