Re: Fix pg_stat_reset_single_table_counters function

Masahiro Ikeda <ikedamsh@oss.nttdata.com>

From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers@lists.postgresql.org, mitsuru.hinata.5432@gmail.com
Date: 2023-08-15T05:13:46Z
Lists: pgsql-hackers

Attachments

On 2023-08-15 11:48, Masahiko Sawada wrote:
> On Mon, Aug 14, 2023 at 5:12 PM Masahiro Ikeda 
> <ikedamsh@oss.nttdata.com> wrote:
>> I changed the table to check the stats from pg_database to
>> pg_shdescription
>> because the stats can update via the SQL interface COMMENT command.
> 
> It seems to work well.
> 
> +COMMENT ON DATABASE :current_database IS 'This is a test comment';
> -- insert or update in 'pg_shdescription'
> 
> I think the current_database should be quoted (see other examples
> where using current_database(), e.g. collate.linux.utf8.sql). Also it
> would be better to reset the comment after the test.

Thanks! I fixed the issues in the v4 patch.

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION

Commits

  1. Fix pg_stat_reset_single_table_counters() for shared relations