Re: WIP: Covering + unique indexes.

Teodor Sigaev <teodor@sigaev.ru>

From: Teodor Sigaev <teodor@sigaev.ru>

To: "Shinoda, Noriyoshi" <noriyoshi.shinoda@hpe.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Geoghegan <pg@bowt.ie>, Jeff Janes <jeff.janes@gmail.com>, Anastasia Lubennikova <a.lubennikova@postgrespro.ru>

Date: 2018-04-09T14:56:44Z

Lists: pgsql-hackers

Thanks to both of you, pushed

Shinoda, Noriyoshi wrote:
> Hi!
> 
> Thank you for your response.
> 
> I think that it is good with your proposal.
> 
> Regards,
> 
> Noriyoshi Shinoda
> 
> *From:*Alexander Korotkov [mailto:a.korotkov@postgrespro.ru]
> *Sent:* Monday, April 9, 2018 11:22 PM
> *To:* Shinoda, Noriyoshi <noriyoshi.shinoda@hpe.com>
> *Cc:* PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>; Teodor Sigaev 
> <teodor@sigaev.ru>; Peter Geoghegan <pg@bowt.ie>; Jeff Janes 
> <jeff.janes@gmail.com>; Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
> *Subject:* Re: WIP: Covering + unique indexes.
> 
> Hi!
> 
> On Mon, Apr 9, 2018 at 5:07 PM, Shinoda, Noriyoshi <noriyoshi.shinoda@hpe.com 
> <mailto:noriyoshi.shinoda@hpe.com>> wrote:
> 
>     I tested this feature and found a document shortage in the columns added to
>     the pg_constraint catalog.
>     The attached patch will add the description of the 'conincluding' column to
>     the manual of the pg_constraint catalog.
> 
> Thank you for pointing this!
> 
> I think we need more wordy explanation here.  My proposal is attached.
> 
> ------
> Alexander Korotkov
> Postgres Professional: http://www.postgrespro.com <http://www.postgrespro.com/>
> The Russian Postgres Company
> 

-- 
Teodor Sigaev                                   E-mail: teodor@sigaev.ru
                                                    WWW: http://www.sigaev.ru/

Commits

Adjust INCLUDE index truncation comments and code.
- 075aade4361b 11.0 landed
Add commentary explaining why MaxIndexTuplesPerPage calculation is safe.
- 2a67d6440db4 11.0 cited
Indexes with INCLUDE columns and their support in B-tree
- 8224de4f42cc 11.0 landed
Add amcheck verification of heap relations belonging to btree indexes.
- 7f563c09f890 11.0 cited
Doc: move info for btree opclass implementors into main documentation.
- 3785f7eee3d9 11.0 cited
Doc: mention that you can't PREPARE TRANSACTION after NOTIFY.
- e4fbf22831c2 11.0 cited
Remove dedicated B-tree root-split record types.
- 0c504a80cf2e 11.0 cited
Restructure index access method API to hide most of it at the C level.
- 65c5fcd353a8 9.6.0 cited
Split _bt_insertonpg to two functions.
- bc292937ae6a 8.3.0 cited
Major overhaul of btree index code. Eliminate special BTP_CHAIN logic for
- 9e85183bfc31 7.1.1 cited