Horton

Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

x4mmm@yandex-team.ru

View thread View on postgr.es
From: Andrey Borodin <x4mmm@yandex-team.ru>
To: Teodor Sigaev <teodor@sigaev.ru>
Cc: Shubham Barai <shubhambaraiss@gmail.com>, Alexander Korotkov <a.korotkov@postgrespro.ru>, Andrew Borodin <amborodin86@gmail.com>, Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers <pgsql-hackers@postgresql.org>, Kevin Grittner <kgrittn@gmail.com>
Date: 2018-03-27T08:16:19Z
Lists: pgsql-hackers 
Hi1

> 27 марта 2018 г., в 12:53, Teodor Sigaev <teodor@sigaev.ru> написал(а):
> 
> I have a question: why do not CheckForSerializableConflictIn() move  into begining of gistplacetopage()? Seems, it is the single function which actually changes page and all predicate locking stuff will be placed in single function...

gistplacetopage() is called from
1. Buffered build - probably harmless
2. Finish split - i'm not sure about this. It seems to me that it is necessary... then your version is correct.

Best regards, Andrey Borodin.

Commits

  1. Add predicate locking for GiST