Horton

Re: postgres_fdw: Oddity in pushing down inherited UPDATE/DELETE joins to remote servers

Amit Langote <langote_amit_f8@lab.ntt.co.jp>

View thread View on postgr.es
From: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>, Robert Haas <robertmhaas@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2018-05-17T05:26:33Z
Lists: pgsql-hackers

Attachments

On 2018/05/17 14:19, Amit Langote wrote:
> Looking at this for a bit, I wondered if this crash wouldn't have occurred
> if the "propagation" had also considered join relations in addition to
> simple relations.  For example, if I changed inheritance_planner like the
> attached (not proposing that we consider committing it), reported crash
> doesn't occur.  The fact that it's not currently that way means that
> somebody thought that there is no point in keeping all of those joinrels
> around until plan creation time.  If that is so, is it a bit worrying that
> a FDW function invoked from createplan.c may try to look for one?

Oops, I forgot to attach the patch that I had used in the experiment.

Thanks,
Amit

Commits

  1. Pass the correct PlannerInfo to PlanForeignModify/PlanDirectModify.

  2. postgres_fdw: Push down UPDATE/DELETE joins to remote servers.