Re: [PATCH] Provide more information to filter_prepare
Markus Wanner <markus.wanner@enterprisedb.com>
From: Markus Wanner <markus.wanner@enterprisedb.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
Ajin Cherian <itsajin@gmail.com>
Date: 2021-03-29T10:00:19Z
Lists: pgsql-hackers
Attachments
- 0001-add-xid-arg-to-filter_prepare_v6.patch (text/x-patch) patch v6-0001
On 29.03.21 11:53, Amit Kapila wrote:
> Okay, but just in the previous sentence ("However, reuse of the same
> <parameter>gid</parameter> for example by a downstream node using
> multiple subscriptions may lead to it not being a unique
> identifier."), you have explained how sending a GID identifier can
> lead to a non-unique identifier for multiple subscriptions.
Maybe the example of the downstream node is a bad one. I understand
that can cause confusion. Let's leave away that example and focus on
the output plugin side. v6 attached.
> And then
> in the next line, the way you are suggesting to generate GID by use of
> XID seems to have the same problem, so that caused confusion for me.
It was not intended as a suggestion for how to generate GIDs at all.
Hopefully leaving away that bad example will make it less likely to
appear related to GID generation on the subscriber.
Regards
Markus
Commits
-
Add a xid argument to the filter_prepare callback for output plugins.
- f64ea6dc5c8c 14.0 landed