Thread

Re: amcheck: support for GiST

Andrey Borodin <x4mmm@yandex-team.ru> — 2025-12-16T12:02:52Z

Hi Miłosz and Sergey!

Thanks a lot for reviewing this patch!

> On 9 Dec 2025, at 23:54, Miłosz Bieniek <bieniek.milosz@proton.me> wrote:
> 
> Hi,
> Together with Sergey we did a review and found a few things that need fixing:
> 
> - `contrib/amcheck/amcheck--1.5--1.6.sql:14` - missing space after comma

Fixed.

> - `verify_gist.c` should be the second entry in meson.build, not at the end

Fixed.

> - Some function arguments like `(GistCheckState * check_state, GistScanItem * stack)` have extra spaces after the `*` - should be `(GistCheckState *check_state, GistScanItem *stack)`

Fixed.

> - Missing `#include "access/itup.h"` in `verify_common.h`

I do not understand why. Perhaps, optimizing headers would be a good idea. This file is not included by any of files that include verify_common.h.

> - Missing test file `007verify_gist_.pl` (not sure if should be created)

I don't think we ever had it for gist.

> - `contrib/amcheck/sql/check_gist.sql` - missing cleanup statement `DROP TABLE toast_bug;`

Fixed.


Thanks!


Best regards, Andrey Borodin.