Re: [PATCH] Add tests for Bitmapset

Daniel Gustafsson <daniel@yesql.se>

From: Daniel Gustafsson <daniel@yesql.se>

To: David Rowley <dgrowleyml@gmail.com>

Cc: Michael Paquier <michael@paquier.xyz>, Greg Burd <greg@burd.me>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-10-02T21:15:15Z

Lists: pgsql-hackers

> On 2 Oct 2025, at 23:00, David Rowley <dgrowleyml@gmail.com> wrote:
> 
> On Fri, 3 Oct 2025 at 01:33, Daniel Gustafsson <daniel@yesql.se> wrote:
>> Another nitpick would be to remove the test for NULL in test_bms_make_singleton
>> since that is a STRICT function, making the test for NULL superfluous code:
> 
> I didn't notice that was marked as strict. It would be good to get rid
> of those lines in that case.

Done, comment cleanup and nullness check pushed.

--
Daniel Gustafsson

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Minor fixes for test_bitmapset.c
- 5142f0093e64 19 (unreleased) landed
test_bitmapset: Improve random function
- 9d46b86529e8 19 (unreleased) landed
Add mem_exceeded_count column to pg_stat_replication_slots.
- d3b6183dd988 19 (unreleased) landed
Tidy-up unneeded NULL parameter checks from SQL function
- a69b55cd4727 19 (unreleased) landed
Remove check for NULL in STRICT function
- 381f5cffae00 19 (unreleased) landed
Fixes for comments in test_bitmapset
- a1b064e4b226 19 (unreleased) landed
Minor fixups of test_bitmapset.c
- 3a6615806859 19 (unreleased) landed
test_bitmapset: Simplify code of the module
- 9952f6c05a40 19 (unreleased) landed
test_bitmapset: Expand more the test coverage
- 5668fff3c512 19 (unreleased) landed
Fix compiler warnings in test_bitmapset
- f83fe65f3fc1 19 (unreleased) landed
Add a test module for Bitmapset
- 00c3d87a5cab 19 (unreleased) landed