Re: pgsql: Allow TRUNCATE foo, foo to succeed, per report from Nikhils.
Dave Page <dpage@pgadmin.org>
From: "Dave Page" <dpage@pgadmin.org>
To: "Simon Riggs" <simon@2ndquadrant.com>
Cc: Nikhils <nikkhils@gmail.com>, "Neil Conway" <neilc@samurai.com>, "Bruce Momjian" <bruce@momjian.us>, pgsql-committers@postgresql.org
Date: 2008-07-17T08:00:53Z
Lists: pgsql-hackers
On Thu, Jul 17, 2008 at 8:48 AM, Simon Riggs <simon@2ndquadrant.com> wrote: > > On Thu, 2008-07-17 at 11:16 +0530, Nikhils wrote: > > >> I presented a simple psql version here. I was actually processing >> multiple relations in my C library in which truncate was invoked on >> all the involved relations. I was passing a list of these rels to >> ExecuteTruncate which barfed when the same rel was mentioned twice in >> that list. Its really an implementation issue as Tom mentioned. > > So you think we should change Postgres rather than your program? > Many people think that on list, and are ignored. > > Why no bug report, proposal or patch? Why during a commit fest? Huh? There was a bug report, with suggested fix on June 5th from Nikhil - http://archives.postgresql.org/pgsql-hackers/2008-06/msg00231.php No-one responded, and over a month later Bruce fixed the bug, pointing out that TRUNCATE is now consistent with LOCK. The fact that Bruce fixed it during a commit fest is irrelevant. Bug fixes don't stop for commit fests, feature freeze's or even releases in many cases - and surely we're not going to tell Bruce he cannot distract himself with a totally different task for 30 minutes or however long it took? -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com