Re: Missing CFI in iterate_word_similarity()
Tom Lane <tgl@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Robins Tharakan <tharakan@gmail.com>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2022-09-02T12:57:00Z
Lists: pgsql-hackers
Daniel Gustafsson <daniel@yesql.se> writes: > Placing code before declarations will generate a compiler warning, so the check > must go after trgindex is declared. I've fixed that in the attached to get the > cfbot green. Marking this ready for committer in the meantime. I noticed the same thing, but sticking the CFI immediately after the declaration didn't read well either. I was considering moving it to the bottom of the loop instead of that. A possible objection is that if there's ever a "continue;" in the loop, those iterations would bypass the CFI; but we don't necessarily need a CFI every time. regards, tom lane
Commits
-
Update out of date comments in pg_trgm
- 6dc0738812c3 16.0 landed
-
Check for interrupts in pg_trgm word similarity
- ae4fc52ae247 16.0 landed
-
Add strict_word_similarity to pg_trgm module
- be8a7a686627 11.0 cited