Horton

Re: aggregate crash

Tom Lane <tgl@sss.pgh.pa.us>

View thread View on postgr.es
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>, Teodor Sigaev <teodor@sigaev.ru>, Pgsql Hackers <pgsql-hackers@postgresql.org>
Date: 2020-01-14T22:01:01Z
Lists: pgsql-hackers 
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> On 2019-Dec-27, Teodor Sigaev wrote:
>> Found crash on production instance, assert-enabled build crashes in pfree()
>> call, with default config. v11, v12 and head are affected, but, seems, you
>> need to be a bit lucky.

> Is this bug being considered for the next set of minors?

I think Andres last touched that code, so I was sort of expecting
him to have an opinion on this.  But I agree that not checking null-ness
explicitly is kind of unsafe.  We've never before had any expectation
that the Datum value of a null is anything in particular.

			regards, tom lane

Commits

  1. Fix edge case leading to agg transitions skipping ExecAggTransReparent() calls.