Horton

Re: BUG #15788: 'pg_dump --create' orders database GRANTs incorrectly

Nathan Bossart <bossartn@amazon.com>

View thread View on postgr.es
From: "Bossart, Nathan" <bossartn@amazon.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>, "pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Date: 2019-05-20T22:37:50Z
Lists: pgsql-bugs 
On 5/20/19, 1:27 AM, "Michael Paquier" <michael@paquier.xyz> wrote:
> I had first a hard time parsing the subqueries added, so I have
> tweaked your patch with more indentation, and a comment block with
> more details about why we need to preserve the ACL ordering (you will
> note that I don't have a lot of imagination here).

Thanks.  Your version looks good to me.

> v12 beta1 is going to ship soon, so let's wait for the version to be
> tagged before committing it.

Sounds good.

Nathan

Commits

  1. Fix ordering of GRANT commands in pg_dumpall for database creation

  2. Fix ordering of GRANT commands in pg_dump for database creation